Skip to content

Modified and cleaned last Java example for Euclidean Algo #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 30, 2018
Merged

Modified and cleaned last Java example for Euclidean Algo #173

merged 4 commits into from
Jun 30, 2018

Conversation

xam4lor
Copy link
Contributor

@xam4lor xam4lor commented Jun 29, 2018

No description provided.

@june128 june128 added the Implementation Edit This provides an edit to an algorithm implementation. (Code and maybe md files are edited.) label Jun 29, 2018
Copy link
Contributor

@zsparal zsparal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the single formatting nitpick this looks good, thanks for the contribution

if (a > b) {
a -= b;
}
else {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should put the else on the same line

@xam4lor
Copy link
Contributor Author

xam4lor commented Jun 30, 2018

And I think that's all!

@zsparal zsparal merged commit 4e0a41b into algorithm-archivists:master Jun 30, 2018
@xam4lor xam4lor deleted the euclid-algo-java branch June 30, 2018 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Implementation Edit This provides an edit to an algorithm implementation. (Code and maybe md files are edited.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants